Electronics & Programming

develissimo

Open Source electronics development and programming

  • You are not logged in.
  • Root
  • » PHP
  • » [PHP-DEV] Re: [PATCH] LSB - new patches for forward_static_call and parent:: forwarding (was: 5.3 Release Planning) [RSS Feed]

#1 March 19, 2008 00:04:49

Etienne K.
Registered: 2009-11-02
Reputation: +  0  -
Profile   Send e-mail  

[PHP-DEV] Re: [PATCH] LSB - new patches for forward_static_call and parent:: forwarding (was: 5.3 Release Planning)


Hello,

the forward_static_call looks like a decent non-intrusive solution,
and your patch looks
good from what I can tell! I guess you should commit it so it can be
documented and all.

regards

On Tue, Mar 18, 2008 at 7:55 PM, Mike Lively <> wrote:
> On Thu, Mar 13, 2008 at 6:48 AM, Mike Lively <> wrote:
>
> >
> > New patches can be found at
> >http://www.digitalsandwich.com/Patches/index.html> >
> > I have fixed the forward_static_call (I am not attached to the name and am
> > open to suggestions) patch to use a callable. In doing this I also added an
> > additional check to make sure the called_class is only forwarded if the
> > class whose method being called is an ancestor of the current class. If
> that
> > is not the case, then the behaviour will actually be identical to
> > call_user_func*.
> >
> > I created against patch for both 5_3 and 6.
> >
> > I have also updated and attached that parent:: forwarding patch for both
> > 5_3 and 6. In the event that someone wants to look at that (PLEASE??? ;)).
> >
> > - Mike Lively
> >
>
> Has anyone had a chance to look at this? I don't want to forget about it
> again or before I know it 5.3 RCs will be out and I will have missed the
> boat...again...
>



--
Etienne Kneusshttp://www.colder.chMen never do evil so completely and cheerfully as
when they do it from a religious conviction.
-- Pascal

--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit:http://www.php.net/unsub.php

Offline

#2 March 20, 2008 04:15:38

Mike L.
Registered: 2009-11-02
Reputation: +  0  -
Profile   Send e-mail  

[PHP-DEV] Re: [PATCH] LSB - new patches for forward_static_call and parent:: forwarding (was: 5.3 Release Planning)


On Tue, Mar 18, 2008 at 4:04 PM, Etienne Kneuss <> wrote:

> Hello,
>
> the forward_static_call looks like a decent non-intrusive solution,
> and your patch looks
> good from what I can tell! I guess you should commit it so it can be
> documented and all.


If by 'you' you mean me...I can't. I don't have any cvs karma, or an account
for that matter. I am going to go ahead and write the tests and add them to
a new copy of the patch. Then it will be ready for someone to commit.

To answer Stanislav's question yes, the forward_static_call patch will
suffice my concerns with the current implementation. You did mention that
you weren't a big fan of the name, I am not particularly attached to it
either. If you (or anyone else) has better name in mind I would be happy to
change it.

Offline

#3 March 20, 2008 19:21:24

Stanislav M.
Registered: 2009-11-02
Reputation: +  0  -
Profile   Send e-mail  

[PHP-DEV] Re: [PATCH] LSB - new patches for forward_static_call and parent:: forwarding (was: 5.3 Release Planning)


To answer Stanislav's question yes, the forward_static_call patch will
suffice my concerns with the current implementation. You did mention that
you weren't a big fan of the name, I am not particularly attached to it
either. If you (or anyone else) has better name in mind I would be happy to
change it.Great. Could you just add a couple of tests - to both verify it worksand illustrate the idea? Then I guess it'll be ready to commit.--
Stanislav Malyshev, Zend Software Architect
http://www.zend.com/(408)253-8829 MSN:

--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit:http://www.php.net/unsub.php

Offline

#4 March 20, 2008 22:29:09

Joseph N.
Registered: 2009-11-02
Reputation: +  0  -
Profile   Send e-mail  

[PHP-DEV] Re: [PATCH] LSB - new patches for forward_static_call and parent:: forwarding (was: 5.3 Release Planning)


Could I just get a confirmation that the parent forwarding patch has
been looked at? It seems to me that the patch makes parent:: work as
one would expect when extending static methods, and would not cause
any backwards compatibility problems. Why is add a function preferred?

Thanks,

Joseph North

On Thu, Mar 20, 2008 at 11:20 AM, Stanislav Malyshev <> wrote:
> > To answer Stanislav's question yes, the forward_static_call patch will
> > suffice my concerns with the current implementation. You did mention that
> > you weren't a big fan of the name, I am not particularly attached to it
> > either. If you (or anyone else) has better name in mind I would be happy to
> > change it.
>
> Great. Could you just add a couple of tests - to both verify it works
> and illustrate the idea? Then I guess it'll be ready to commit.
>
> --
> Stanislav Malyshev, Zend Software Architect
> http://www.zend.com/> (408)253-8829 MSN:
>
> --
>
>
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit:http://www.php.net/unsub.php>
>

--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit:http://www.php.net/unsub.php

Offline

  • Root
  • » PHP
  • » [PHP-DEV] Re: [PATCH] LSB - new patches for forward_static_call and parent:: forwarding (was: 5.3 Release Planning) [RSS Feed]

Board footer

Moderator control

Enjoy the 16th of December
PoweredBy

The Forums are managed by develissimo stuff members, if you find any issues or misplaced content please help us to fix it. Thank you! Tell us via Contact Options
Leave a Message
Welcome to Develissimo Live Support