Electronics & Programming

develissimo

Open Source electronics development and programming

  • You are not logged in.
  • Root
  • » PHP
  • » [PHP-DEV] re2c scanner issue [RSS Feed]

#1 March 25, 2008 11:19:54

Dmitry S.
Registered: 2009-11-02
Reputation: +  0  -
Profile   Send e-mail  

[PHP-DEV] re2c scanner issue


Hi Marcus,The ext/tokenizer/tests/token_get_all_variation17.phpt is probably thelast broken test. It has a memleak. I am not trying to fix it becauseyou should know it much better, also re2c scanner is not ported to HEADyet and you may keep changes that must be ported.BTW PHP_5_3 became faster. Good work!

Thanks. Dmitry.

--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit:http://www.php.net/unsub.php

Offline

#2 March 25, 2008 11:28:36

Marcus B.
Registered: 2009-11-02
Reputation: +  0  -
Profile   Send e-mail  

[PHP-DEV] re2c scanner issue


Hello Dmitry,

Tuesday, March 25, 2008, 11:19:08 AM, you wrote:

> Hi Marcus,

> The ext/tokenizer/tests/token_get_all_variation17.phpt is probably the

There are probably more changes coming so there is not so much need to
change this part right now.

> last broken test. It has a memleak. I am not trying to fix it because
> you should know it much better, also re2c scanner is not ported to HEAD
> yet and you may keep changes that must be ported.

Yep we're aware of this. Right now Scott is doing the MFB to HEAD part and
last time I talked with him he made pretty good progress. I updated a lot
of stuff in re2c to give myself more freedom in how to address the task of
bringing back multibyte support back in. I also started on the PHP side and
fixed quite a bunch of issues in the multibyte code so far. The good news
is that my normal build still works as expected.

> BTW PHP_5_3 became faster. Good work!

Good to hear from others. Did you do any profiling you could share?

Best regards,
Marcus


--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit:http://www.php.net/unsub.php

Offline

#3 March 25, 2008 11:47:11

Dmitry S.
Registered: 2009-11-02
Reputation: +  0  -
Profile   Send e-mail  

[PHP-DEV] re2c scanner issue


Sorry, but I didn't store benchmarks before re2c patch so I can justcompare PHP_5_3 and PHP_5_2.Drupal 20% faster
Qdig 2% faster
typo3 30% faster
wordpress 15% faster
xoops 10% fasterNot all the speedup caused by re2c scanner, but it makes significantpart of it.Thanks. Dmitry.


Marcus Boerger wrote:Hello Dmitry,

Tuesday, March 25, 2008, 11:19:08 AM, you wrote:Hi Marcus,The ext/tokenizer/tests/token_get_all_variation17.phpt is probably theThere are probably more changes coming so there is not so much need to
change this part right now.last broken test. It has a memleak. I am not trying to fix it becauseyou should know it much better, also re2c scanner is not ported to HEADyet and you may keep changes that must be ported.Yep we're aware of this. Right now Scott is doing the MFB to HEAD part and
last time I talked with him he made pretty good progress. I updated a lot
of stuff in re2c to give myself more freedom in how to address the task of
bringing back multibyte support back in. I also started on the PHP side and
fixed quite a bunch of issues in the multibyte code so far. The good news
is that my normal build still works as expected.BTW PHP_5_3 became faster. Good work!Good to hear from others. Did you do any profiling you could share?

Best regards,
Marcus--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit:http://www.php.net/unsub.php

Offline

#4 March 25, 2008 13:47:48

Marcus B.
Registered: 2009-11-02
Reputation: +  0  -
Profile   Send e-mail  

[PHP-DEV] re2c scanner issue


Hello Dmitry, Johannes

wow! so we all together made pretty good progress. We really need to
announce that, maybe to make people help in getting the release straight?

marcus

Tuesday, March 25, 2008, 11:46:20 AM, you wrote:

> Sorry, but I didn't store benchmarks before re2c patch so I can just
> compare PHP_5_3 and PHP_5_2.

> Drupal 20% faster
> Qdig 2% faster
> typo3 30% faster
> wordpress 15% faster
> xoops 10% faster

> Not all the speedup caused by re2c scanner, but it makes significant
> part of it.

> Thanks. Dmitry.


> Marcus Boerger wrote:
>> Hello Dmitry,
>>
>> Tuesday, March 25, 2008, 11:19:08 AM, you wrote:
>>
>>> Hi Marcus,
>>
>>> The ext/tokenizer/tests/token_get_all_variation17.phpt is probably the
>>
>> There are probably more changes coming so there is not so much need to
>> change this part right now.
>>
>>> last broken test. It has a memleak. I am not trying to fix it because
>>> you should know it much better, also re2c scanner is not ported to HEAD
>>> yet and you may keep changes that must be ported.
>>
>> Yep we're aware of this. Right now Scott is doing the MFB to HEAD part and
>> last time I talked with him he made pretty good progress. I updated a lot
>> of stuff in re2c to give myself more freedom in how to address the task of
>> bringing back multibyte support back in. I also started on the PHP side and
>> fixed quite a bunch of issues in the multibyte code so far. The good news
>> is that my normal build still works as expected.
>>
>>> BTW PHP_5_3 became faster. Good work!
>>
>> Good to hear from others. Did you do any profiling you could share?
>>
>> Best regards,
>> Marcus
>>




Best regards,
Marcus


--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit:http://www.php.net/unsub.php

Offline

#5 March 25, 2008 14:16:29

Christian S.
Registered: 2009-11-02
Reputation: +  0  -
Profile   Send e-mail  

[PHP-DEV] re2c scanner issue


Dmitry Stogov wrote:
> Drupal 20% faster
> Qdig 2% faster
> typo3 30% faster
> wordpress 15% faster
> xoops 10% faster

Out of curiosity: I assume this is without an opcode cache?

- Chris

--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit:http://www.php.net/unsub.php

Offline

#6 March 25, 2008 14:23:15

David Z.
Registered: 2009-11-02
Reputation: +  0  -
Profile   Send e-mail  

[PHP-DEV] re2c scanner issue


of course. how can you measure scanner performance with an opcodecache on :pDavid



Am 25.03.2008 um 14:15 schrieb Christian Schneider:Dmitry Stogov wrote:Drupal 20% faster
Qdig 2% faster
typo3 30% faster
wordpress 15% faster
xoops 10% fasterOut of curiosity: I assume this is without an opcode cache?

- Chris

--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit:http://www.php.net/unsub.php--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit:http://www.php.net/unsub.php

Offline

#7 March 25, 2008 14:33:15

Christian S.
Registered: 2009-11-02
Reputation: +  0  -
Profile   Send e-mail  

[PHP-DEV] re2c scanner issue


David Zülke wrote:
> of course. how can you measure scanner performance with an opcode cache
> on :p

That's what I thought. It also means my initial excitement is gone as we
(as anyone running anything but a personal home page) are using opcode
caches anyway. I basically just wanted it to be mentioned to avoid the
impression that people will actually see a 20% speed-up by this.

- Chris

--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit:http://www.php.net/unsub.php

Offline

#8 March 25, 2008 14:33:53

Dmitry S.
Registered: 2009-11-02
Reputation: +  0  -
Profile   Send e-mail  

[PHP-DEV] re2c scanner issue


Of course.

Dmitry.

Christian Schneider wrote:Dmitry Stogov wrote:Drupal 20% faster
Qdig 2% faster
typo3 30% faster
wordpress 15% faster
xoops 10% fasterOut of curiosity: I assume this is without an opcode cache?

- Chris--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit:http://www.php.net/unsub.php

Offline

#9 March 25, 2008 14:39:00

Scott M.
Registered: 2009-11-02
Reputation: +  0  -
Profile   Send e-mail  

[PHP-DEV] re2c scanner issue


The opcode cache skips out the scanning, parsing and compilation stepsafter the first run.So if you have an opcode cache you're only going to see benefit thefirst time before its stored.Scott

Christian Schneider wrote:David Z|lke wrote:of course. how can you measure scanner performance with an opcode cache
on :pThat's what I thought. It also means my initial excitement is gone as we
(as anyone running anything but a personal home page) are using opcode
caches anyway. I basically just wanted it to be mentioned to avoid the
impression that people will actually see a 20% speed-up by this.

- Chris--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit:http://www.php.net/unsub.php

Offline

#10 March 25, 2008 19:16:19

Marcus B.
Registered: 2009-11-02
Reputation: +  0  -
Profile   Send e-mail  

[PHP-DEV] re2c scanner issue


Hello David,

Tuesday, March 25, 2008, 2:22:31 PM, you wrote:

> of course. how can you measure scanner performance with an opcode
> cache on :p

Note that Dmitry wrote that he did not isolate the scanner performance
alone. I would assume that the bigger parts of listed speedups are based on
other changes, going through NEWS you will find quite a bunch of changes
that have impact on speed. And most of them apply whether tehre is an
opcode cache or not.

marcus

> Am 25.03.2008 um 14:15 schrieb Christian Schneider:
>> Dmitry Stogov wrote:
>>> Drupal 20% faster
>>> Qdig 2% faster
>>> typo3 30% faster
>>> wordpress 15% faster
>>> xoops 10% faster
>>
>> Out of curiosity: I assume this is without an opcode cache?
>>
>> - Chris
>>
>> --
>> PHP Internals - PHP Runtime Development Mailing List
>> To unsubscribe, visit:http://www.php.net/unsub.php>>
>>





Best regards,
Marcus


--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit:http://www.php.net/unsub.php

Offline

  • Root
  • » PHP
  • » [PHP-DEV] re2c scanner issue [RSS Feed]

Board footer

Moderator control

Enjoy the 11th of December
PoweredBy

The Forums are managed by develissimo stuff members, if you find any issues or misplaced content please help us to fix it. Thank you! Tell us via Contact Options
Leave a Message
Welcome to Develissimo Live Support