Electronics & Programming

develissimo

Open Source electronics development and programming

  • You are not logged in.
  • Root
  • » PHP
  • » [PHP-DEV] ext/mbstring dependencies [RSS Feed]

#1 Dec. 6, 2010 10:22:07

Hannes M.
Registered: 2009-11-02
Reputation: +  0  -
Profile   Send e-mail  

[PHP-DEV] ext/mbstring dependencies


On Mon, Dec 6, 2010 at 09:31, Dmitry Stogov <dmi***@*end.com> wrote:
> Hi,
>
> The proposed patch completely removes ext/mbstring compile-time
> dependencies. As result the same php binaries may be used for Asian and
> European languages without performance degradation. ext/mbstring now may be
> compiled as a DSO. I'm going to commit the patch on Wednesday.
> Any comments are welcome.
>

Random scrolling through the patch:
Index: ext/mbstring/mbstring.c

+// to = php_mb_convert_encoding(from, from_len, encoding_to,
encoding_from, to_length);
+// return to ? 0 : -1;
and WS
+ !memcmp("none", name, sizeof("none") - 1)))) {


-Hannes

--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit:http://www.php.net/unsub.php

Offline

#2 Dec. 6, 2010 10:40:04

Dmitry S.
Registered: 2009-11-02
Reputation: +  0  -
Profile   Send e-mail  

[PHP-DEV] ext/mbstring dependencies


Thanks. Already removed it.

Dmitry.

On 12/06/2010 01:21 PM, Hannes Magnússon wrote:On Mon, Dec 6, 2010 at 09:31, Dmitry Stogov<dmi***@*end.com> wrote:Hi,

The proposed patch completely removes ext/mbstring compile-time
dependencies. As result the same php binaries may be used for Asian and
European languages without performance degradation. ext/mbstring now may be
compiled as a DSO. I'm going to commit the patch on Wednesday.
Any comments are welcome.Random scrolling through the patch:
Index: ext/mbstring/mbstring.c

+// to = php_mb_convert_encoding(from, from_len, encoding_to,
encoding_from, to_length);
+// return to ? 0 : -1;
and WS
+ !memcmp("none", name, sizeof("none") - 1)))) {


-Hannes--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit:http://www.php.net/unsub.php

Offline

#3 Dec. 6, 2010 17:40:09

Moriyoshi K.
Registered: 2009-11-02
Reputation: +  0  -
Profile   Send e-mail  

[PHP-DEV] ext/mbstring dependencies


Hi,

The patch almost looks good to me, but we should be more careful about
introducing a set of hook points into the API. I think it'd be great
if the multipart parser portion was rewritten so that it would only
call the Zend multibyte API's despite a slight performance drawback.

Regards,
Moriyoshi

On Mon, Dec 6, 2010 at 5:31 PM, Dmitry Stogov <dmi***@*end.com> wrote:
> Hi,
>
> The proposed patch completely removes ext/mbstring compile-time
> dependencies. As result the same php binaries may be used for Asian and
> European languages without performance degradation. ext/mbstring now may be
> compiled as a DSO. I'm going to commit the patch on Wednesday.
> Any comments are welcome.
>
> Thanks. Dmitry.
>
> --
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit:http://www.php.net/unsub.php>

--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit:http://www.php.net/unsub.php

Offline

#4 Dec. 6, 2010 20:50:05

Dmitry S.
Registered: 2009-11-02
Reputation: +  0  -
Profile   Send e-mail  

[PHP-DEV] ext/mbstring dependencies


On 12/06/2010 08:38 PM, Moriyoshi Koizumi wrote:Hi,

The patch almost looks good to me, but we should be more careful about
introducing a set of hook points into the API. I think it'd be great
if the multipart parser portion was rewritten so that it would only
call the Zend multibyte API's despite a slight performance drawback.Really I thought in the same way, but finally I decided not to putRFC1867 specific callbacks into zend engine, because ZE does nothingrelated to RFC1867 handling at all.Thanks. Dmitry.Regards,
Moriyoshi

On Mon, Dec 6, 2010 at 5:31 PM, Dmitry Stogov<dmi***@*end.com> wrote:Hi,

The proposed patch completely removes ext/mbstring compile-time
dependencies. As result the same php binaries may be used for Asian and
European languages without performance degradation. ext/mbstring now may be
compiled as a DSO. I'm going to commit the patch on Wednesday.
Any comments are welcome.

Thanks. Dmitry.

--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit:http://www.php.net/unsub.php--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit:http://www.php.net/unsub.php

Offline

  • Root
  • » PHP
  • » [PHP-DEV] ext/mbstring dependencies [RSS Feed]

Board footer

Moderator control

Enjoy the 20th of October
PoweredBy

The Forums are managed by develissimo stuff members, if you find any issues or misplaced content please help us to fix it. Thank you! Tell us via Contact Options
Leave a Message
Welcome to Develissimo Live Support