Electronics & Programming

develissimo

Open Source electronics development and programming

  • You are not logged in.
  • Root
  • » KiCAD
  • » [Kicad-developers] Default Field names patch [RSS Feed]

#1 May 13, 2010 15:19:35

Dick H.
Registered: 2009-11-02
Reputation: +  0  -
Profile   Send e-mail  

[Kicad-developers] Default Field names patch


Brian Sidebotham wrote:Hi Guys,

Sorry I've been quiet for a while, I've been extremely busy building
my rally car.http links to fancy pictures, please.About a month ago I had a discussion with Wayne with regards to the
patch that is attached. I have updated the patch so that it applies to
the current testing branch.

To refresh, this patch adds the ability to have a custom default
setting for component field names. Thus Field1 could instead be
Manufacturer, or any other chosen default which saves the user from
having to input this information for every component they create.
Currently the patch puts these defaults in the .pro project file. As
Wayne pointed out there are two problems here:

(1) The .pro project file is probably not the best place to store
these default names.
(2) The defaults are currently edited from the eeschema settings
dialog, and therefore are in the wrong place for .pro project file
settings anyway.

There are a couple of formatting issues with the code and the GUI
rules are not adhered to in this patch, so that needs cleaning up for
a start, but I wanted to get people's opinion on where these default
names should be stored.

It would seem sane to put them in the eeschema options, this would
mean that the settings could be left in the current GUI placement.

If everyone is in agreement, or abstains then I'll tidy up the GUI
implementation and change the patch so that the options get saved
along with the eeschema options. I'll also tidy up the code
formatting.The feature sounds very useful.Best Regards,

Brian._______________________________________________
Mailing list:https://launchpad.net/~kicad-developersPost to : kicad-developers@lists.launchpad.net
Unsubscribe :https://launchpad.net/~kicad-developersMore help :https://help.launchpad.net/ListHelp

Offline

#2 May 14, 2010 01:44:47

Brian S.
Registered: 2009-11-02
Reputation: +  0  -
Profile   Send e-mail  

[Kicad-developers] Default Field names patch


On 13 May 2010 15:19, Dick Hollenbeck <d***@*oftplc.com> wrote:
> Brian Sidebotham wrote:
>>
>> Hi Guys,
>>
>> Sorry I've been quiet for a while, I've been extremely busy building
>> my rally car.
>>
>
> http links to fancy pictures, please.

No problem, here is a picture-heavy page:http://www.valvers.com/Brian_S-StageRallyOpelManta-DiaryI have some open-hardware projects I want to do for it.

>> About a month ago I had a discussion with Wayne with regards to the
>> patch that is attached. I have updated the patch so that it applies to
>> the current testing branch.
>>
>> To refresh, this patch adds the ability to have a custom default
>> setting for component field names. Thus Field1 could instead be
>> Manufacturer, or any other chosen default which saves the user from
>> having to input this information for every component they create.
>> Currently the patch puts these defaults in the .pro project file. As
>> Wayne pointed out there are two problems here:
>>
>> (1) The .pro project file is probably not the best place to store
>> these default names.
>> (2) The defaults are currently edited from the eeschema settings
>> dialog, and therefore are in the wrong place for .pro project file
>> settings anyway.
>>
>> There are a couple of formatting issues with the code and the GUI
>> rules are not adhered to in this patch, so that needs cleaning up for
>> a start, but I wanted to get people's opinion on where these default
>> names should be stored.
>>
>> It would seem sane to put them in the eeschema options, this would
>> mean that the settings could be left in the current GUI placement.
>>
>> If everyone is in agreement, or abstains then I'll tidy up the GUI
>> implementation and change the patch so that the options get saved
>> along with the eeschema options. I'll also tidy up the code
>> formatting.
>>
>
> The feature sounds very useful.
>

Thanks for the feedback. Hopefully I'll finalise it next week and get
it out of the way.

Best Regards,

Brian.

_______________________________________________
Mailing list:https://launchpad.net/~kicad-developersPost to : kicad-developers@lists.launchpad.net
Unsubscribe :https://launchpad.net/~kicad-developersMore help :https://help.launchpad.net/ListHelp

Offline

#3 May 14, 2010 12:45:31

Dick H.
Registered: 2009-11-02
Reputation: +  0  -
Profile   Send e-mail  

[Kicad-developers] Default Field names patch


Brian Sidebotham wrote:No problem, here is a picture-heavy page:http://www.valvers.com/Brian_S-StageRallyOpelManta-DiaryI have some open-hardware projects I want to do for it.Very cool. My Dad used to race 1/4 mile dirt cars when I was a kid, Iwatched him build one, complete with roll bar cage, new suspension,starting from a normal street car he bought for about $200. He and hispartner rebuilt the engine, even built the trailer for it using a autorepair hydraulic lift stand. Used a 1/4 beer keg aluminum container forthe gas tank. All very low budget.What you are up to looks like a lot of fun.

Dick


_______________________________________________
Mailing list:https://launchpad.net/~kicad-developersPost to : kicad-developers@lists.launchpad.net
Unsubscribe :https://launchpad.net/~kicad-developersMore help :https://help.launchpad.net/ListHelp

Offline

#4 May 14, 2010 21:08:39

Brian S.
Registered: 2009-11-02
Reputation: +  0  -
Profile   Send e-mail  

[Kicad-developers] Default Field names patch


On 14 May 2010 12:43, Dick Hollenbeck <d***@*oftplc.com> wrote:
> Brian Sidebotham wrote:
>>
>> No problem, here is a picture-heavy page:
>>http://www.valvers.com/Brian_S-StageRallyOpelManta-Diary>> I have some open-hardware projects I want to do for it.
>>
> Very cool.  My Dad used to race 1/4 mile dirt cars when I was a kid, I
> watched him build one, complete with roll bar cage, new suspension, starting
> from a normal street car he bought for about $200.  He and his partner
> rebuilt the engine, even built the trailer for it using a auto repair
> hydraulic lift stand.  Used a 1/4 beer keg aluminum container for the gas
> tank.  All very low budget.
>
> What you are up to looks like a lot of fun.

Cheers, hopefully the really fun bit is what comes now! :)

I am eager to get on with some of the electronics projects i have in
mind for it.

Best Regards,

Brian,

_______________________________________________
Mailing list:https://launchpad.net/~kicad-developersPost to : kicad-developers@lists.launchpad.net
Unsubscribe :https://launchpad.net/~kicad-developersMore help :https://help.launchpad.net/ListHelp

Offline

#5 May 27, 2010 16:46:59

Dick H.
Registered: 2009-11-02
Reputation: +  0  -
Profile   Send e-mail  

[Kicad-developers] Default Field names patch


Brian Sidebotham wrote:
> Hi Guys,
>
> About a month ago I had a discussion with Wayne with regards to the
> patch that is attached. I have updated the patch so that it applies to
> the current testing branch.
>
> To refresh, this patch adds the ability to have a custom default
> setting for component field names. Thus Field1 could instead be
> Manufacturer, or any other chosen default which saves the user from
> having to input this information for every component they create.
> Currently the patch puts these defaults in the .pro project file. As
> Wayne pointed out there are two problems here:
>
> (1) The .pro project file is probably not the best place to store
> these default names.
> (2) The defaults are currently edited from the eeschema settings
> dialog, and therefore are in the wrong place for .pro project file
> settings anyway.
>
> There are a couple of formatting issues with the code and the GUI
> rules are not adhered to in this patch, so that needs cleaning up for
> a start, but I wanted to get people's opinion on where these default
> names should be stored.
>
> It would seem sane to put them in the eeschema options, this would
> mean that the settings could be left in the current GUI placement.
>
> If everyone is in agreement, or abstains then I'll tidy up the GUI
> implementation and change the patch so that the options get saved
> along with the eeschema options. I'll also tidy up the code
> formatting.
>
> Best Regards,
>
> Brian.
>

I would like to fixhttps://bugs.launchpad.net/kicad/+bug/581153Will that screw up your patch?

Brian please let us know if this revised patch is in the near term. If
not, I will do the bug fix soon.

Thanks,

Dick



_______________________________________________
Mailing list:https://launchpad.net/~kicad-developersPost to : kicad-developers@lists.launchpad.net
Unsubscribe :https://launchpad.net/~kicad-developersMore help :https://help.launchpad.net/ListHelp

Offline

#6 May 29, 2010 20:59:16

Brian S.
Registered: 2009-11-02
Reputation: +  0  -
Profile   Send e-mail  

[Kicad-developers] Default Field names patch


> I would like to fixhttps://bugs.launchpad.net/kicad/+bug/581153>
> Will that screw up your patch?
>
> Brian please  let us know if this revised patch is in the near term.  If
> not, I will do the bug fix soon.
>
> Thanks,
>
> Dick

Hi Dick,

I left this patch whilst I went on holiday to Germany. I've just got
back today. It will take me a week to find enough time to complete the
patch, if I say I can post a completed patch next Friday would that be
okay?

There is not really much to do to complete this patch, sorry it's
dragged on a bit.

Best Regards,

Brian.

_______________________________________________
Mailing list:https://launchpad.net/~kicad-developersPost to : kicad-developers@lists.launchpad.net
Unsubscribe :https://launchpad.net/~kicad-developersMore help :https://help.launchpad.net/ListHelp

Offline

#7 June 7, 2010 14:08:01

Dick H.
Registered: 2009-11-02
Reputation: +  0  -
Profile   Send e-mail  

[Kicad-developers] Default Field names patch


Brian Sidebotham wrote:
> On 29 May 2010 20:58, Brian Sidebotham <brian.sidebot***@*mail.com> wrote:
>
>>> I would like to fixhttps://bugs.launchpad.net/kicad/+bug/581153>>>
>>> Will that screw up your patch?
>>>
>>> Brian please let us know if this revised patch is in the near term. If
>>> not, I will do the bug fix soon.
>>>
>>> Thanks,
>>>
>>> Dick
>>>
>> Hi Dick,
>>
>> I left this patch whilst I went on holiday to Germany. I've just got
>> back today. It will take me a week to find enough time to complete the
>> patch, if I say I can post a completed patch next Friday would that be
>> okay?
>>
>> There is not really much to do to complete this patch, sorry it's
>> dragged on a bit.
>>
>> Best Regards,
>>
>> Brian.
>>
>
> Hi Guys,
>
> Please find a revised patch attached. Changes are to the GUI layout as
> advised by Wayne, and the default field names are now saved under the
> eeschema options as opposed to a project file. This makes much more
> sense and the options are saved when the eeschema options dialog
> returns OK along with the other eeschema options. There are also a few
> code formatting improvements too, hopefully I've caught all of the
> formatting issues.
>
> Wayne, please check the GUI changes to the dialog for me just to make
> sure I understood the problems correctly, I don't want to mess up all
> the work you've done in tidying up the GUI.
>
> Sorry this patch took so long to complete!
>
> Best Regards,
>
> Brian.
>

+
+void DIALOG_EESCHEMA_OPTIONS::SetFieldName( int aNdx, wxString aName )
+{


I don't recall there being a limit to the number of fields in the
symbols. I could be wrong, but that is not what I recall adding support
for when I added expandable field name lists. The above function has a
limit to the number of field names, and maybe this is a limit imposed by
the dialog UI (probably undesirable if so).

The patch is probably good enough for me to dove tail it into the code
base, if you don't mind some minor changes.

I'll get started later this week. And then do the BOM fix at that time
also.


Thanks,

Dick


_______________________________________________
Mailing list:https://launchpad.net/~kicad-developersPost to : kicad-developers@lists.launchpad.net
Unsubscribe :https://launchpad.net/~kicad-developersMore help :https://help.launchpad.net/ListHelp

Offline

#8 June 7, 2010 14:35:04

Brian S.
Registered: 2009-11-02
Reputation: +  0  -
Profile   Send e-mail  

[Kicad-developers] Default Field names patch


> +
> +void DIALOG_EESCHEMA_OPTIONS::SetFieldName( int aNdx, wxString aName )
> +{
>
>
> I don't recall there being a limit to the number of fields in the
> symbols.  I could be wrong, but that is not what I recall adding support
> for when I added expandable field name lists.  The above function has a
> limit to the number of field names, and maybe this is a limit imposed by
> the dialog UI (probably undesirable if so).

Hi Dick,

Yes that's right this is a limit imposed by the dialog UI. It would be
much better to have an expandable default list in the UI. Whilst I had
my head in the code I forgot that you had added the ability to add
extra custom fields in your field edit dialog, hence I wrongly assumed
DEFAULT_NUMBER_OF_FIELDS (previously NUMBER_OF_FIELDS) was the limit.

> The patch is probably good enough for me to dove tail it into the code
> base, if you don't mind some minor changes.

I don't mind changes to it at all, please do whatever you feel
necessary. I'll observe the changes and learn a bit more!

> I'll get started later this week.  And then do the BOM fix at that time
> also.

Best Regards,

Brian.

_______________________________________________
Mailing list:https://launchpad.net/~kicad-developersPost to : kicad-developers@lists.launchpad.net
Unsubscribe :https://launchpad.net/~kicad-developersMore help :https://help.launchpad.net/ListHelp

Offline

#9 June 8, 2010 01:20:33

Wayne S.
Registered: 2009-11-02
Reputation: +  0  -
Profile   Send e-mail  

[Kicad-developers] Default Field names patch


On 6/7/2010 9:07 AM, Dick Hollenbeck wrote:
> Brian Sidebotham wrote:
>> On 29 May 2010 20:58, Brian Sidebotham <brian.sidebot***@*mail.com> wrote:
>>
>>>> I would like to fixhttps://bugs.launchpad.net/kicad/+bug/581153>>>>
>>>> Will that screw up your patch?
>>>>
>>>> Brian please let us know if this revised patch is in the near term. If
>>>> not, I will do the bug fix soon.
>>>>
>>>> Thanks,
>>>>
>>>> Dick
>>>>
>>> Hi Dick,
>>>
>>> I left this patch whilst I went on holiday to Germany. I've just got
>>> back today. It will take me a week to find enough time to complete the
>>> patch, if I say I can post a completed patch next Friday would that be
>>> okay?
>>>
>>> There is not really much to do to complete this patch, sorry it's
>>> dragged on a bit.
>>>
>>> Best Regards,
>>>
>>> Brian.
>>>
>>
>> Hi Guys,
>>
>> Please find a revised patch attached. Changes are to the GUI layout as
>> advised by Wayne, and the default field names are now saved under the
>> eeschema options as opposed to a project file. This makes much more
>> sense and the options are saved when the eeschema options dialog
>> returns OK along with the other eeschema options. There are also a few
>> code formatting improvements too, hopefully I've caught all of the
>> formatting issues.
>>
>> Wayne, please check the GUI changes to the dialog for me just to make
>> sure I understood the problems correctly, I don't want to mess up all
>> the work you've done in tidying up the GUI.
>>
>> Sorry this patch took so long to complete!
>>
>> Best Regards,
>>
>> Brian.
>>
>
> +
> +void DIALOG_EESCHEMA_OPTIONS::SetFieldName( int aNdx, wxString aName )
> +{
>
>
> I don't recall there being a limit to the number of fields in the
> symbols. I could be wrong, but that is not what I recall adding support
> for when I added expandable field name lists. The above function has a
> limit to the number of field names, and maybe this is a limit imposed by
> the dialog UI (probably undesirable if so).

Dick,

This is partly my fault as I completely forgot that you made the change
to eliminate the fixed number of fields. So it would make sense to
change the dialog to remove the fixed number of default field values.

>
> The patch is probably good enough for me to dove tail it into the code
> base, if you don't mind some minor changes.
>
> I'll get started later this week. And then do the BOM fix at that time
> also.

Thanks for handling this. I probably wouldn't be able to get to it for
at least another two weeks.

Wayne

>
>
> Thanks,
>
> Dick
>
>
> _______________________________________________
> Mailing list:https://launchpad.net/~kicad-developers> Post to : kicad-develop***@*ists.launchpad.net
> Unsubscribe :https://launchpad.net/~kicad-developers> More help :https://help.launchpad.net/ListHelp>

_______________________________________________
Mailing list:https://launchpad.net/~kicad-developersPost to : kicad-developers@lists.launchpad.net
Unsubscribe :https://launchpad.net/~kicad-developersMore help :https://help.launchpad.net/ListHelp

Offline

#10 June 10, 2010 10:35:32

Brian S.
Registered: 2009-11-02
Reputation: +  0  -
Profile   Send e-mail  

[Kicad-developers] Default Field names patch


>
> Thanks for handling this.  I probably wouldn't be able to get to it for
> at least another two weeks.
>
> Wayne

Echo that, thanks for dealing with this patch Dick. If the GUI change
adds too much work, feel free to push this back to me to change, as
the configuration loading and saving will have to change too (as they
use for( size_t i=0; i<DEFAULT_NUMBER_OF_FIELDS; i++) loops).

I have some free time at the weekend where I could sort it out if needed.

Also just to add, I've been getting on with bazaar version control
really well, it proved very handy with this patch as I was easily able
to create a quick branch and then occasionally merge with the testing
branch head to keep it relevant.

Best Regards,

Brian.

_______________________________________________
Mailing list:https://launchpad.net/~kicad-developersPost to : kicad-developers@lists.launchpad.net
Unsubscribe :https://launchpad.net/~kicad-developersMore help :https://help.launchpad.net/ListHelp

Offline

  • Root
  • » KiCAD
  • » [Kicad-developers] Default Field names patch [RSS Feed]

Board footer

Moderator control

Enjoy the 20th of October
PoweredBy

The Forums are managed by develissimo stuff members, if you find any issues or misplaced content please help us to fix it. Thank you! Tell us via Contact Options
Leave a Message
Welcome to Develissimo Live Support