Electronics & Programming

develissimo

Open Source electronics development and programming

  • You are not logged in.
  • Root
  • » PHP
  • » [PHP-DEV] [PATCH] bug #34429 - Output buffering cannot be turned off with FastCGI [RSS Feed]

#1 Dec. 7, 2005 16:01:21

Ilya M.
Registered: 2009-11-02
Reputation: +  0  -
Profile   Send e-mail  

[PHP-DEV] [PATCH] bug #34429 - Output buffering cannot be turned off with FastCGI


Hi,

Now, flush() works in fastcgi...
It seems, that the developers forgot about lazy compilation!-)
What do you think about that?

Best rgds, Ilya? khext.patch
Index: sapi/cgi/cgi_main.c
===================================================================
RCS file: /repository/php-src/sapi/cgi/cgi_main.c,v
retrieving revision 1.271
diff -u -r1.271 cgi_main.c
--- sapi/cgi/cgi_main.c 3 Dec 2005 01:27:37 -0000 1.271
+++ sapi/cgi/cgi_main.c 6 Dec 2005 21:58:18 -0000
@@ -264,13 +264,15 @@

static void sapi_cgibin_flush(void *server_context)
{
- if (!FCGX_IsCGI()) {
+ int flush_result;
+ if (!FCGX_IsCGI()) {
FCGX_Request *request = (FCGX_Request *) server_context;
- if (
+ flush_result = FCGX_FFlush(request->out);
+ if (
#ifndef PHP_WIN32
!parent &&
#endif
- (!request || FCGX_FFlush(request->out) == -1)) {
+ (!request || flush_result == -1)) {
php_handle_aborted_connection();
}
return;--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit:http://www.php.net/unsub.php

Offline

#2 Dec. 7, 2005 16:01:53

Ilya M.
Registered: 2009-11-02
Reputation: +  0  -
Profile   Send e-mail  

[PHP-DEV] [PATCH] bug #34429 - Output buffering cannot be turned off with FastCGI


Hi,

Now, flush() works in fastcgi...
It seems, that the developers forgot about lazy compilation!-)
What do you think about that?

Best rgds, Ilya? khext.patch
Index: sapi/cgi/cgi_main.c
===================================================================
RCS file: /repository/php-src/sapi/cgi/cgi_main.c,v
retrieving revision 1.271
diff -u -r1.271 cgi_main.c
--- sapi/cgi/cgi_main.c 3 Dec 2005 01:27:37 -0000 1.271
+++ sapi/cgi/cgi_main.c 6 Dec 2005 21:58:18 -0000
@@ -264,13 +264,15 @@

static void sapi_cgibin_flush(void *server_context)
{
- if (!FCGX_IsCGI()) {
+ int flush_result;
+ if (!FCGX_IsCGI()) {
FCGX_Request *request = (FCGX_Request *) server_context;
- if (
+ flush_result = FCGX_FFlush(request->out);
+ if (
#ifndef PHP_WIN32
!parent &&
#endif
- (!request || FCGX_FFlush(request->out) == -1)) {
+ (!request || flush_result == -1)) {
php_handle_aborted_connection();
}
return;--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit:http://www.php.net/unsub.php

Offline

#3 Dec. 7, 2005 17:09:32

Dmitry S.
Registered: 2009-11-02
Reputation: +  0  -
Profile   Send e-mail  

[PHP-DEV] [PATCH] bug #34429 - Output buffering cannot be turned off with FastCGI


Hi Ilya,

Your patch is wring.
It may try access request->out then request is NULL.

Thanks. Dmitry.

> -----Original Message-----
> From: Ilya M. Slepnev
> Sent: Wednesday, December 07, 2005 1:08 AM
> To: intern***@*ists.php.net
> Cc:
> Subject: bug #34429 - Output buffering
> cannot be turned off with FastCGI
>
>
> Hi,
>
> Now, flush() works in fastcgi...
> It seems, that the developers forgot about lazy
> compilation!-) What do you think about that?
>
> Best rgds, Ilya
>

--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit:http://www.php.net/unsub.php

Offline

#4 Dec. 7, 2005 17:25:04

Ilya M.
Registered: 2009-11-02
Reputation: +  0  -
Profile   Send e-mail  

[PHP-DEV] [PATCH] bug #34429 - Output buffering cannot be turned off with FastCGI


Hi Dmitry,

What about adding "if (request) " at the beginning of the
"flush_result = FCGX_FFlush(request->out);" string? You see, you have
to do that call, because else you are not flushing at all in fastcgi
mode at all!-)

Thanks, Ilya.

12/7/2005, "Dmitry Stogov" <> вы писали:

>Hi Ilya,
>
>Your patch is wring.
>It may try access request->out then request is NULL.
>
>Thanks. Dmitry.
>
>> -----Original Message-----
>> From: Ilya M. Slepnev
>> Sent: Wednesday, December 07, 2005 1:08 AM
>> To: intern***@*ists.php.net
>> Cc:
>> Subject: bug #34429 - Output buffering
>> cannot be turned off with FastCGI
>>
>>
>> Hi,
>>
>> Now, flush() works in fastcgi...
>> It seems, that the developers forgot about lazy
>> compilation!-) What do you think about that?
>>
>> Best rgds, Ilya
>>
>

--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit:http://www.php.net/unsub.php

Offline

  • Root
  • » PHP
  • » [PHP-DEV] [PATCH] bug #34429 - Output buffering cannot be turned off with FastCGI [RSS Feed]

Board footer

Moderator control

Enjoy the 20th of January
PoweredBy

The Forums are managed by develissimo stuff members, if you find any issues or misplaced content please help us to fix it. Thank you! Tell us via Contact Options
Leave a Message
Welcome to Develissimo Live Support